-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Improve](audit) sql that fails to be syntax parsed is not audited #48527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
could u add more clearly description? |
|
run buildall |
TPC-H: Total hot run time: 31652 ms |
TPC-DS: Total hot run time: 184624 ms |
ClickBench: Total hot run time: 30.44 s |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 31916 ms |
TPC-DS: Total hot run time: 184527 ms |
ClickBench: Total hot run time: 31.06 s |
fe/fe-core/src/main/java/org/apache/doris/qe/AuditLogHelper.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
Outdated
Show resolved
Hide resolved
|
run buildall |
TPC-H: Total hot run time: 31892 ms |
TPC-DS: Total hot run time: 190880 ms |
ClickBench: Total hot run time: 30.76 s |
|
run buildall |
TPC-H: Total hot run time: 32859 ms |
TPC-DS: Total hot run time: 192251 ms |
ClickBench: Total hot run time: 30.62 s |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 32352 ms |
|
run buildall |
TPC-DS: Total hot run time: 190758 ms |
ClickBench: Total hot run time: 27.66 s |
|
PR approved by at least one committer and no changes requested. |
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
TPC-DS: Total hot run time: 189738 ms |
ClickBench: Total hot run time: 28.14 s |
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
ClickBench: Total hot run time: 29.33 s |
…48527) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #47595 Problem Summary: For PR #47595 , set `stmt` to `error messsage` of `org.apache.doris.qe.QueryState.ErrType#ANALYSIS_ERR` of query audit, so many of the original SQL will be abandoned, this is very unreasonable, It is now more appropriate to set stmt to error message only for queries that are syntax parsed incorrectly Now only sql with syntax errors is ignored Co-authored-by: garenshi <garenshi@tencent.com>
…pache#48527) ### What problem does this PR solve? Issue Number: close #xxx Related PR: apache#47595 Problem Summary: For PR apache#47595 , set `stmt` to `error messsage` of `org.apache.doris.qe.QueryState.ErrType#ANALYSIS_ERR` of query audit, so many of the original SQL will be abandoned, this is very unreasonable, It is now more appropriate to set stmt to error message only for queries that are syntax parsed incorrectly Now only sql with syntax errors is ignored Co-authored-by: garenshi <garenshi@tencent.com>
…48527) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #47595 Problem Summary: For PR #47595 , set `stmt` to `error messsage` of `org.apache.doris.qe.QueryState.ErrType#ANALYSIS_ERR` of query audit, so many of the original SQL will be abandoned, this is very unreasonable, It is now more appropriate to set stmt to error message only for queries that are syntax parsed incorrectly Now only sql with syntax errors is ignored Co-authored-by: garenshi <garenshi@tencent.com>
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #47595
Problem Summary:
For PR #47595 , set
stmttoerror messsageoforg.apache.doris.qe.QueryState.ErrType#ANALYSIS_ERRof query audit, so many of the original SQL will be abandoned, this is very unreasonable, It is now more appropriate to set stmt to error message only for queries that are syntax parsed incorrectlyNow only sql with syntax errors is ignored
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)